DRAFT: Add tags to exports #364
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @theyostalservice and the rest of your teammates on |
theyostalservice
commented
Nov 6, 2024
| @@ -159,27 +159,48 @@ def test_saved_query_exports() -> None: | |||
| export_as: VIEW | |||
| schema: my_schema | |||
| alias: my_view_name | |||
| tags: "tag_1" | |||
There was a problem hiding this comment.
This line won't validate, because it's not a list. :/
The added print statement I put in below gives us this info:
SemanticManifestValidationResults(warnings=(), future_errors=(), errors=(
ValidationError(message='1 validation error for PydanticSavedQuery\nexports -> 0 -> config -> tags\n
value is not a valid list (type=type_error.list)', context=FileContext(file_name='inline_for_test', line_number=1), extra_detail=' File "/Users/patricky/git/dbt-semantic-interfaces/dbt_semantic_interfaces/parsing/dir_to_model.py", line 343, in parse_config_yaml\n results.append(saved_query_class.parse_obj(object_cfg))\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n File "pydantic/main.py", line 526, in pydantic.main.BaseModel.parse_obj\n File "pydantic/main.py", line 341, in pydantic.main.BaseModel.__init__\n'),))
theyostalservice
force-pushed
the
patricky_add_tags_to_exports
branch
from
8a40ff0 to
2ecdea5
Compare
theyostalservice
force-pushed
the
patricky_add_tags_to_exports
branch
from
2ecdea5 to
b55ab15
Compare
|
This PR closed because exports can't be searched by tags right now - they are not implemented as nodes in dbt - so this doesn't serve a purpose. It's been replaced by work to add tags to SavedQueries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #
Description
Checklist
changie newto create a changelog entry